Repository navigation
Conversation
3638075 to
5b2f058
Compare
|
@MikeMcC399 here is what the Still need to resolve the buildmatrix version comparison issue |
4f35f28 to
565be84
Compare
|
|
||
| const getFullNodeVersionFromDockerfile = (file) => | ||
| fs.readFileSync(file, 'utf8').match(/^ENV NODE_VERSION=(\d*\.*\d*\.\d*)/m)[1]; | ||
| fs.readFileSync(file, 'utf8').match(/^ENV NODE_VERSION=(\S*)/m)[1]; |
There was a problem hiding this comment.
tried to use a real semver regex, but figured out that those are multi-match, and this was "good enough"
| let tags; | ||
|
|
||
| if (isAlpha) { | ||
| // Only push explicit variants during the Alpha phase |
There was a problem hiding this comment.
Made a call not to include any plain 27, 27.0.0, etc tags during the Alpha, and only have specific versions that people are explictly opting into.
| } | ||
| }, | ||
| "26": { | ||
| "start": "2026-05-05", |
There was a problem hiding this comment.
This wasn't used, and was copy/pasted from the nodejs/Release values anyway.
There are sometimes gaps there, but that isn't fixed by have a value here
|
I wasn't expecting this to happen so fast, so thanks for putting this together! I like that there are no floating tags for this Alpha release! As you know this is still very much in general discussion with lots of different opinions! (nodejs/node#67135 & nodejs/Release#1171) I'm not sure if Alpine Linux 3.23 should be included in 27 Alpha as this will be short-lived. Alpine Linux plans for new releases every May and November, so I'd expect an Alpine Linux 3.25 in the next weeks, which we'd want to transition to and then drop Alpine Linux 3.23. There should also be some documentation added to the README about Alpha. I'm also not sure if we should release this one, or just treat it as a dry-run exercise and wait for the next Alpha release. There hasn't been any user specifically asking for an Alpha Docker build so far. There is no release plan in https://github.com/nodejs/Release/issues for Node.js 27 Alpha, but I'd expect a 2-week cadence like previous current versions have had, which would mean Nov 11, 2026 for the next one. Maybe @sxa from the releasers team can help us understand the plans? |
MikeMcC399
left a comment
There was a problem hiding this comment.
I already left some comments about the Alpha release.
I'm wondering if the stackbrew enhancement commit should be extracted into its own PR, since this is a general improvement which helps also for other release lines, not just the 27 Alpha.
|
Also I just discovered that there is no published link to the documentation. nodejs/nodejs.org#9254 |
|
Yeah, I started this PR as a small stackbrew one, but ended up morphing it into the 27 one, since I needed that part to test out how it would handle the Alpha concept. |
1b385f3 to
da3c47d
Compare
|
I think this could likely land as-is with the minimal v27. |
da3c47d to
a26b642
Compare
MikeMcC399
left a comment
There was a problem hiding this comment.
I'm OK for going ahead with releasing Node.js Docker images with pinned tags based on 27.0.0-alpha.0.0.0
Decisions about floating tags still need more discussion.
| "alpine3.23": [ | ||
| "amd64", | ||
| "arm64v8" | ||
| ], |
There was a problem hiding this comment.
I think we could drop alpine3.23 for Node.js 27 Alpha since it will get dropped in the next weeks anyway if Alpine Linux releases 3.25 and we move to building only 3.24 / 3.25. alpine3.23 certainly won't make it through to when Node.js 27.0.0 moves to current status in April 2027, so there wouldn't be much value in testing it.
Not a blocker - just a comment.
There was a problem hiding this comment.
yeah, all the images/tags will be deleted with each new Alpha release, so it would get deleted pretty shortly anyway
There was a problem hiding this comment.
Any published images with their tags would stay on Docker Hub, but there aren't any floating tags right now, so that makes it less of an issue.
|
@nodejs/docker it would be good to get some more reviews on this one, since it's a larger change to the releases in this repo |
Description
Adds the new Node.js 27 Alpha release.
Motivation and Context
Converts the stackbrew as a first step to make the external file calls a bit easier.
Drops local
version.jsonmetadata for the source of truths upstream in the nodejs/Release and individual release's index.json metadata.Testing Details
Example Output(if appropriate)
Types of changes
Checklist