fix: resolve broken links - #965
Conversation
PR SummaryLow Risk Overview On the homepage, the generators reference, specification link, and “What’s next” list (getting started, commands, configuration, generators) now use Reviewed by Cursor Bugbot for commit 74d3e72. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
When I contributed this, there was review feedback that they were not necessary. 🤷 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 195 195
Lines 17938 17938
Branches 1632 1632
=======================================
Hits 15540 15540
Misses 2392 2392
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
8.89 MB | 8.89 MB | +1.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 6.1% slower (8.16 s → 8.66 s)
- Peak memory: 3.0% lower (1.86 GB → 1.80 GB)
web Generator
Output size: 2 files changed · net 0 B
File size details
| File | Main | PR | Change |
|---|---|---|---|
assets/all-CrZzA5_i.js |
22.13 MB | — | -22.13 MB (-100.0%) |
assets/all-FOceAO_p.js |
— | 22.13 MB | +22.13 MB |
Performance estimate (single CI run)
- Generation time: 25.3% slower (59.78 s → 74.92 s)
- Peak memory: 1.3% lower (5.25 GB → 5.18 GB)
There was a problem hiding this comment.
Pull request overview
Updates the doc-kit documentation site’s narrative Markdown pages to link to the generated .html outputs, resolving broken internal navigation on doc-kit.nodejs.org.
Changes:
- Update internal relative links in
www/pages/index.mdto point to*.htmltargets. - Update “Next steps” links in
www/pages/getting-started.mdto point to*.htmltargets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| www/pages/index.md | Converts internal doc links to explicit .html targets for the generated site output. |
| www/pages/getting-started.md | Converts “Next steps” internal links to explicit .html targets for correct navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can't you enable |
I dunno, can I? I don't know what layer of the stack this is being suggested for 😄 - making the code just more accurate feels easier. This is broken right now, we should fix it. |
|
this is broken and should be fixed - merging - if someone wants to fast-follow with something more elegant, 👍 |
Description
Every single one of these is broken over on doc-kit.nodejs.org
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.