-
Notifications
You must be signed in to change notification settings - Fork 58
refactor(node): extract @doc-kittens/node package #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@doc-kittens/node': major | ||
| '@node-core/doc-kit': minor | ||
| --- | ||
|
|
||
| The Node.js-specific generators (`api-links`, `addon-verify`, and | ||
| `man-page`) now live in the new `@doc-kittens/node` package and are loaded | ||
| via import specifiers such as `@doc-kittens/node/man-page`. The CLI | ||
| shorthand names are unchanged. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import dedent from 'dedent'; | |
| const updateJsRequirePaths = content => { | ||
| return dedent` | ||
| 'use strict'; | ||
| const common = require('../../common'); | ||
| const common = require('@node-core/doc-kit/generators/common'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrong require in generated testsHigh Severity
Reviewed by Cursor Bugbot for commit 1043c7e. Configure here.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤦 Find + Replace always has quirks |
||
| ${content.replace( | ||
| "'./build/Release/addon'", | ||
| '`./build/${common.buildType}/addon`' | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing node package manifest
High Severity
The new
@doc-kittens/nodepackage is registered in the lockfile and wired up via shorthand aliases, butpackages/node/package.jsonis absent. Without a manifest and exports map, imports such as@doc-kittens/node/man-pagecannot resolve, soman-page,addon-verify, andapi-linksfail to load.Additional Locations (2)
package-lock.json#L11399-L11411.changeset/node-kitten-package.md#L1-L9Reviewed by Cursor Bugbot for commit 1043c7e. Configure here.