Skip to content

fix(processing): only include .name when it exists#833

Open
avivkeller wants to merge 1 commit into
mainfrom
fix/title-processing
Open

fix(processing): only include .name when it exists#833
avivkeller wants to merge 1 commit into
mainfrom
fix/title-processing

Conversation

@avivkeller
Copy link
Copy Markdown
Member

No description provided.

@avivkeller avivkeller requested a review from a team as a code owner June 6, 2026 20:20
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 6, 2026

PR Summary

Low Risk
Single conditional in HTML title assembly with no auth, data, or API behavior changes.

Overview
Fixes how generated HTML <title> values are built in processJSXEntries when populating the page template.

Previously every page used `${data.heading.data.name} | ${titleSuffix}`, so entries without heading.data.name (e.g. metadata with empty heading data) could get malformed titles such as a leading "undefined |" or a bare pipe. The logic now uses the `name | suffix` form only when data.heading.data.name is truthy; otherwise the title is just the configured titleSuffix.

Reviewed by Cursor Bugbot for commit 06f10d5. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Jun 6, 2026 8:22pm

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.33%. Comparing base (75e291a) to head (06f10d5).

Files with missing lines Patch % Lines
src/generators/web/utils/processing.mjs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   84.34%   84.33%   -0.01%     
==========================================
  Files         172      172              
  Lines       15447    15449       +2     
  Branches     1367     1368       +1     
==========================================
+ Hits        13028    13029       +1     
- Misses       2409     2410       +1     
  Partials       10       10              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

web Generator

File Base Head Diff
all.html 19.73 MB 19.73 MB +4.00 B (+0.00%)

@AugustinMauroy
Copy link
Copy Markdown
Member

Could you add rest thanks ☺️

@avivkeller
Copy link
Copy Markdown
Member Author

Maybe in a follow-up, this file isn't currently tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants