Skip to content

feat(shiki): more langs#754

Open
avivkeller wants to merge 2 commits intomainfrom
feat/shiki/langs
Open

feat(shiki): more langs#754
avivkeller wants to merge 2 commits intomainfrom
feat/shiki/langs

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Apr 6, 2026

Adds support for languages used by Node-API (CMake and Python)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Apr 6, 2026 4:35pm

Request Review

@avivkeller avivkeller requested a review from a team as a code owner April 6, 2026 16:32
Copilot AI review requested due to automatic review settings April 6, 2026 16:32
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 6, 2026

PR Summary

Low Risk
Low risk: only extends syntax-highlighter configuration by registering two additional Shiki languages, with no runtime logic or data handling changes.

Overview
Adds cmake and python to the registered Shiki languages in shiki.config.mjs, expanding syntax highlighting coverage for the API docs while keeping the existing theme setup and JavaScript aliases unchanged.

Reviewed by Cursor Bugbot for commit 4e31f6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.43%. Comparing base (b2330d9) to head (4e31f6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   78.42%   78.43%           
=======================================
  Files         157      157           
  Lines       13959    13963    +4     
  Branches     1152     1152           
=======================================
+ Hits        10948    10952    +4     
  Misses       3006     3006           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Shiki language registrations needed to syntax-highlight code blocks found in Node-API related docs (CMake, Gyp, Python) within this repo’s Shiki highlighter configuration.

Changes:

  • Import Shiki language definitions for cmake, gyp, and python.
  • Register those languages in the exported Shiki langs list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...cLanguage,
...cPlusPlusLanguage,
...coffeeScriptLanguage,
...cmakeLanguage,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I foresee our bundle doing kaboom

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is server-only is it not?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 possibly? Hopefully yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants