Fix(web): hide empty navbar space on mobile #554
Closed
+156
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Marella <arvindmarella31@gmail.com>
Signed-off-by: Arvind Marella <arvindmarella31@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
requested changes
Dec 27, 2025
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Thanks for your PR!
You should be able to achieve this with CSS-only changes.
Note that the ui directory should already have a css file (or it should be somewhere nearby)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #533 where the mobile navigation header shows a chunk of empty space when there are no navigation menu entries. The web UI now hides the empty space in the navbar. It also ensures the web CSS bundling step consistently preserves the generated CSS during bundling, and contains tests to cover the CSS bundling behavior.
Validation
Before:
After:
Related Issues
Fixes #533
Check List
node --run testand all tests passed.node --run format&node --run lint.