Skip to content

test: remove esbuild config for vitest#846

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
MikeMcC399:no-esbuild-target-vitest
May 15, 2026
Merged

test: remove esbuild config for vitest#846
aduh95 merged 1 commit into
nodejs:mainfrom
MikeMcC399:no-esbuild-target-vitest

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 commented May 15, 2026

Situation

corepack yarn test outputs the warning similar to the following:

Both esbuild and oxc options were set. oxc options will be used and esbuild options will be ignored. The following esbuild options were set: { target: 'node24.14.1' }

esbuild: {
target: `node${process.versions.node}`,
},

Change

In vitest.config.mts remove the conflicting esbuild.target

This is being ignored and oxc automatically targets the current Node.js version, which is also the intention of the esbuild key.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 15, 2026 12:30
@aduh95 aduh95 merged commit 8b73a65 into nodejs:main May 15, 2026
9 checks passed
@MikeMcC399 MikeMcC399 deleted the no-esbuild-target-vitest branch May 15, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants