fix: target node 22.22.2 in esbuild#845
Merged
Merged
Conversation
Contributor
Author
|
Testing chores CI failure is a known issue #837 This test is successful locally running Node.js 24.14.1 |
aduh95
approved these changes
May 15, 2026
Contributor
Author
|
requires PR #847 to succeed in CI reliably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
The npm script
build:bundleselectsesbuild --target=node18.17.0See
This may unnecessarily transform JavaScript syntax to the earlier EOL Node.js 18 version, although the repo is now set to minimum Node.js 22.22.2
corepack/package.json
Lines 12 to 14 in 05bc5f3
Change
Update
build:bundleto--target=node22.22.2