Supported state in case of denial#99
Merged
jankapunkt merged 2 commits intonode-oauth:developmentfrom Dec 10, 2021
Merged
Conversation
release 4.1.1 -> master
33 tasks
Member
|
please set target to development not master |
Contributor
Author
|
Hi, done Regards |
jankapunkt
approved these changes
Dec 10, 2021
Member
|
@HappyZombies @jwerre can you please second-check and merge, if approved? |
jwerre
approved these changes
Dec 10, 2021
|
@jankapunkt are you planning a release including this fix anytime soon? Our projects depend on this fix, and I'd like to return to a public version 👍 |
Member
|
Hey @ronaldsteen I currently prepare to finish our automated release workflow, see #117 once this is merged (one workflow is not tested yet, which is the one running for a new release) then I want to create |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr is related to issue #89, with point 13 and 20 (original pr oauthjs/node-oauth2-server#576 and oauthjs/node-oauth2-server#649 respectively).
It adds the missing state parameter.
Linked issue(s)
The reference issue is the #89.
Added tests?
Yes, and updated already existent tests.
OAuth2 standard
RFC6749, section 4.1.2.1