Skip to content

refactor: replace lint/fmt with unified vp check #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 4 commits into from
Feb 28, 2026
+76 −86
Merged

refactor: replace lint/fmt with unified vp check #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d7ba11
refactor: replace lint/fmt with unified vp check
fengmk2 Feb 28, 2026
6df1e75
chore: update vite-plus to latest for vp check support
fengmk2 Feb 28, 2026
c5be7ca
fix: use non-mutating vp run check in test script
fengmk2 Feb 28, 2026
2fd80e3
chore: pnpm dedupe
fengmk2 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,15 @@ jobs:
cache: true
run-install: true

- name: Run lint
run: vp run lint
- name: Check
run: vp run check

- name: Check dedupe
run: vp dedupe --check

- name: Run typecheck
run: vp run typecheck

- name: Run format check
run: vp run fmtcheck

- name: Run build check
run: vp run build

Expand Down Expand Up @@ -67,9 +64,6 @@ jobs:
cache: true
run-install: true

- name: Run lint
run: vp run lint

- name: Run tests
run: vp run ci

Expand Down
14 changes: 5 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,7 @@
"tag": "latest"
},
"scripts": {
"lint": "vp lint src test --type-aware --type-check",
"typecheck": "tsc --noEmit && tsgo --noEmit",
"fmt": "vp fmt",
"fmtcheck": "vp fmt --check",
"prebuild": "vp run clean",
"build": "vp run build:ts && vp run build:version",
"build:ts": "tsc --version && tshy && tshy-after",
Expand All @@ -61,15 +58,17 @@
"test-tsc:cjs": "cd test/fixtures/ts && rm -rf node_modules && npm link ../../.. && vp run build",
"test-tsc:cjs:es2021": "cd test/fixtures/ts-cjs-es2021 && rm -rf node_modules && npm link ../../.. && vp run build",
"test-tsc:esm": "cd test/fixtures/ts-esm && rm -rf node_modules && npm link ../../.. && vp run build",
"test": "vp run lint -- --fix && vp test run --reporter=dot",
"test": "vp run check && vp test run --reporter=dot",
"bench": "vp test bench",
"test-keepalive": "cross-env TEST_KEEPALIVE_COUNT=50 vp test run --reporter=dot --test-timeout 180000 keep-alive-header.test.ts",
"test-node16": "node examples/httpclient.cjs && node examples/search_github.cjs && node examples/timing.cjs",
"cov": "vp test run --reporter=dot --coverage",
"ci": "vp run cov && vp run prepublishOnly && npm pack && attw --pack",
"clean": "rm -rf dist && tsc -b --clean",
"prepublishOnly": "vp run build",
"prepare": "husky"
"prepare": "husky",
"check": "vp check",
"check:fix": "vp check --fix"
Comment on lines 47 to +71
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the lint/fmt scripts and replaces them with check/check:fix, but repo docs still reference the old commands (e.g. CLAUDE.md mentions pnpm run lint and pnpm run fmt). Update the documentation to reflect the new script names so contributors don’t follow broken instructions.

Copilot uses AI. Check for mistakes.
},
"dependencies": {
"form-data": "^4.0.5",
Expand Down Expand Up @@ -114,10 +113,7 @@
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
},
"lint-staged": {
"*": [
"vp run lint --fix",
"vp fmt --no-error-on-unmatched-pattern"
]
"*": "vp check --fix"
},
"tshy": {
"exports": {
Expand Down
138 changes: 69 additions & 69 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading