Added appending to data file instead as a strecht goal#21
Open
simbs wants to merge 1 commit intonode-girls:masterfrom
Open
Added appending to data file instead as a strecht goal#21simbs wants to merge 1 commit intonode-girls:masterfrom
simbs wants to merge 1 commit intonode-girls:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the workshop I changed the code to be able to only append a new post to the data file instead of reading all of it, parsing, adding to the string and rewriting everything. However, the way I've done it means posts.json is no longer a true JSON file, so I don't think this version should replace the original method which allows to explain what JSON is.
I haven't added my solution to it, let me know if you think I should include it (and where!).