bar widget - clock: added setting, use selected color for the capsule#2131
Open
ViSovereign wants to merge 3 commits intonoctalia-dev:mainfrom
Open
bar widget - clock: added setting, use selected color for the capsule#2131ViSovereign wants to merge 3 commits intonoctalia-dev:mainfrom
ViSovereign wants to merge 3 commits intonoctalia-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Add a new setting to the clock widget, use the selected color as the capsule color. text will become Color.mOnPrimary when toggled.
Motivation
I wanted to give the clock more visibility options for when a user quickly glanced over to see the time while doing an activity like gaming.
Type of Change
Mark the relevant option with an "x".
Related Issue
n/a
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
Checklist
Additional Notes
Regarding documentation, I am not aware of what next steps would be if any.