Update custom figures/tables vignette#443
Merged
sbreitbart-NOAA merged 17 commits intodevfrom Apr 15, 2026
Merged
Conversation
…ess-redundant vignette
…ad of creating new qmds; update workflow for adding figures/tables as qmds
Contributor
Checklist
|
Contributor
Code Metrics Report
Reported by octocov |
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Schiano-NOAA
reviewed
Apr 9, 2026
Collaborator
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
There was a problem hiding this comment.
This is great! What an awesome resource for out users. I left a few comments to help with clarity and also questions. Could you figure out how to add a navigational side bar for the vignette now? It is pretty long and dense so I could see it being a bit complex to navigate especially when they already read through it and just want to find a specific part.
Once those changes are made, then good to merge :)
Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com>
Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com>
Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com>
Collaborator
Author
Thanks so much for your detailed review, Sam. I've addressed your suggestions and will merge in a moment! |
Schiano-NOAA
added a commit
that referenced
this pull request
Apr 15, 2026
* Add NEFSC-specific citations to .bib file (A though R) * Add NEFSC-specific citations to .bib file (S though Z) * Add FAQ about rendering child docs * Update FAQs and markdown vignettes per workshop notes * Updating tests to remove temporary "key_quantities.csv" on exit * Update custom figures/tables vignette (#443) * Create snippets for custom figs/tables vignette; add to redesigned, less-redundant vignette * Update snippet header formatting so tabs in main vignette work * Update guidance to use gt package for tables * Update vignette snippet about IDing table width/length and splitting * Alter workflow so that user adds to existing figures/tables doc instead of creating new qmds; update workflow for adding figures/tables as qmds * Update coding-in-qmd workflow * Minor fixes * Clarify vignette based on run-through * Update vignettes/snippets/write-caps-alttext.Rmd Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com> * Update vignettes/snippets/save-caps-alttext.Rmd Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com> * Update vignettes/snippets/add-plots_rda.Rmd Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com> * Change header * Resolve #443 (comment) * Resolve several comments from review * Resolve more comments from review * add TOC to vignette * Address last comment about markdown alt text/captions --------- Co-authored-by: Sam Schiano <125507018+Schiano-NOAA@users.noreply.github.com> * Remove manual (#445) * remove manual and link on site * Update wordlist * update version --------- Co-authored-by: sbreitbart-NOAA <sophie.breitbart@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
Does the PR impact any other area of the project, maybe another repo?