docs(examples): use rel instead of type for modulepreload links - #4585
Conversation
The modulepreload hint is set via the rel attribute; type="modulepreload" was a no-op.
|
@cprecioso is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesThe SSR examples for Preact, React, and Solid now use SSR modulepreload updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to React, Preact, and Solid SSR examples now emit standard module preload links, with matching README and documentation updates. The change is limited and ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
The Vite SSR examples create
<link type=modulepreload>tags but it's actually<link rel=modulepreload>(MDN link). Straightforward fix.Disclosure: the patch was written by an AI agent (Claude Code), reviewed and driven by me.