Skip to content

chore: remove unused devDependencies#4302

Merged
pi0 merged 1 commit into
nitrojs:mainfrom
ulrichstark:chore(deps)--uninstall-unused-devDependencies
Jun 30, 2026
Merged

chore: remove unused devDependencies#4302
pi0 merged 1 commit into
nitrojs:mainfrom
ulrichstark:chore(deps)--uninstall-unused-devDependencies

Conversation

@ulrichstark

@ulrichstark ulrichstark commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I tried and failed to integrate knip into this project.
While doing so I noticed these unused devDependencies and uninstalled them.
I hope I didn't break anything.
Less is always better!

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ulrichstark ulrichstark requested a review from pi0 as a code owner June 2, 2026 19:51
@vercel

vercel Bot commented Jun 2, 2026

Copy link
Copy Markdown

@ulrichstark is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0abee732-15b8-4209-8b8a-810791f02873

📥 Commits

Reviewing files that changed from the base of the PR and between cfa7c58 and 38997fc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Removes several unused entries from package.json devDependencies: @types/http-proxy, @types/node-fetch, edge-runtime, expect-type, magic-string, serve-placeholder, and uncrypto.

Changes

Dev dependency cleanup

Layer / File(s) Summary
Remove unused dev dependencies
package.json
Removes @types/http-proxy, @types/node-fetch, edge-runtime, expect-type, magic-string, serve-placeholder, and uncrypto from devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits and accurately summarizes the dependency cleanup.
Description check ✅ Passed The description is clearly related to removing unused devDependencies and the knip attempt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4302

commit: cfa7c58

@socket-security

socket-security Bot commented Jun 11, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@pi0 pi0 changed the title chore(deps): uninstall unused devDependencies chore: remove unused devDependencies Jun 30, 2026
@pi0x pi0x force-pushed the chore(deps)--uninstall-unused-devDependencies branch from 589d8e7 to 38997fc Compare June 30, 2026 12:19

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 24e9459 into nitrojs:main Jun 30, 2026
8 of 9 checks passed
@ulrichstark ulrichstark deleted the chore(deps)--uninstall-unused-devDependencies branch June 30, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants