Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the ImeController and PreferencesView by extracting state monitoring and picker views into dedicated files. It enhances IME state reconciliation by monitoring application focus, space changes, and screen parameter updates, and introduces a periodic reconciliation timer for the menu bar icon. The version is bumped to 1.1.7, and unit tests are expanded to cover the new monitoring logic. Feedback suggests replacing hardcoded delay values with descriptive constants to improve code maintainability.
| let appName = app.localizedName ?? "Unknown" | ||
| Logger.debug("Application activated: \(appName)", category: .ime) | ||
|
|
||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) { [weak self] in |
There was a problem hiding this comment.
The delay 0.2 used for verifying IME state after an app switch is a magic number. Consider defining it as a constant like appSwitchVerificationDelay.
| refreshIconDebounced(delay: 0.12) | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.35) { [weak self] in | ||
| self?.refreshIconDebounced(delay: 0) | ||
| } |
There was a problem hiding this comment.
The magic numbers 0.12 and 0.35 used for debouncing and settling the icon refresh should be defined as constants with descriptive names to explain why these specific delays are necessary.
1 participant
bugfix focus