Repository navigation
Conversation
Contributor
|
Ok I did some work to address some of the test failures. This was done with a bit of duct tape and chewing gum to get things working in terms of transitioning to There are still some modelValues test failures plus a failure with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if this is ready to merge, but let's see if it passes testing and any input from @paciorek.
This simply comments-out the use of
nf_changeNimKeywords, pending discussion of where that should be done. (See #60).I think
calc_dmnormAltParamsandcalc_dwishAltParamswill both work asnCompiler::nFunction. However full testing will really come from uses innimble2.