Repository navigation
Adding Multi Record example in NI-Scope - #2247
Draft
NI-velmurugan wants to merge 2 commits into
Draft
NI-velmurugan wants to merge 2 commits into
NI-velmurugan wants to merge 2 commits into
Conversation
The additional trigger type since this example is independent of the trigger type and the LV as well documented that it is avoided to simplify the VI, but adding this will let the user aware that they can configure any type of trigger instead of just the edge trigger
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2247 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 88 88
Lines 22830 22830
=======================================
+ Hits 20118 20119 +1
+ Misses 2712 2711 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
divakar-selvam07
approved these changes
Oct 28, 2026
| with niscope.Session(resource_name=resource_name, options=options) as session: | ||
| session.configure_vertical(range=vertical_range, coupling=niscope.VerticalCoupling.DC) | ||
| session.configure_horizontal_timing(min_sample_rate=min_sample_rate, min_num_pts=min_record_length, ref_position=50.0, num_records=num_records, enforce_realtime=True) | ||
| # Other trigger types (for example hysteresis or window) can be configured here; IMMEDIATE acquires without an input signal crossing the edge level. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Other trigger types (for example hysteresis or window) can be configured here; IMMEDIATE acquires without an input signal crossing the edge level. | |
| # Configure the selected trigger here; add other trigger types to this block as needed. |
| else: | ||
| session.configure_trigger_immediate() | ||
| with session.initiate(): | ||
| # Fetch waits for all records to be acquired and returns them all. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Fetch waits for all records to be acquired and returns them all. | |
| # Wait for num_records to be acquired, then return their waveforms. |
| import matplotlib.pyplot as plt | ||
|
|
||
| with niscope.Session(resource_name=resource_name, options=options) as session: | ||
| session.configure_vertical(range=vertical_range, coupling=niscope.VerticalCoupling.DC) |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| session.configure_vertical(range=vertical_range, coupling=niscope.VerticalCoupling.DC) | |
| session.channels[channel].configure_vertical(range=vertical_range, coupling=niscope.VerticalCoupling.DC) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
niscope_multi_record.py, a Python adaptation of the LabVIEWniScope EX Multi Record.viWhat testing has been done?
Manually tested the example only using simulated hardware and the real hardware.