Repository navigation
Adding Measurement Library example in NI-Scope - #2245
Draft
NI-velmurugan wants to merge 4 commits into
Draft
NI-velmurugan wants to merge 4 commits into
NI-velmurugan wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
===========================================
- Coverage 88.12% 75.18% -12.94%
===========================================
Files 88 42 -46
Lines 22830 6633 -16197
===========================================
- Hits 20118 4987 -15131
+ Misses 2712 1646 -1066
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
We can use immediate trigger to run the example and the external trigger depends on the external input
| parser.add_argument('-n', '--resource-name', default='PXI1Slot3', help='Specifies the resource name of the device to initialize') | ||
| parser.add_argument('-m', '--scalar-measurement', default='FFT_FREQUENCY', choices=niscope.ScalarMeasurement.__members__.keys(), type=str.upper, help='The scalar measurement to be performed on each fetched waveform.') | ||
| parser.add_argument('--reference-level-units', default='PERCENTAGE', choices=niscope.RefLevelUnits.__members__.keys(), type=str.upper, help='Specifies the units of the reference levels.') | ||
| parser.add_argument('--low-ref', default=10.0, type=float, help='Stores the low reference level used in many scalar measurements.') |
Contributor
There was a problem hiding this comment.
Suggested change
| parser.add_argument('--low-ref', default=10.0, type=float, help='Stores the low reference level used in many scalar measurements.') | |
| parser.add_argument('--low-ref', default=10.0, type=float, help='Specifies the low reference level used by scalar measurements.') |
Contributor
There was a problem hiding this comment.
To be consistent with our other examples, can we rephrase the description in this way?
If so, let's apply this nit change to applicable instances.
Contributor
Author
There was a problem hiding this comment.
This is consistent with the the driver docs, so I am not applying this changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
niscope_measurement_library.py, a Python adaptation of the LabVIEWniScope EX Measurement Library.viWhat testing has been done?
Manually tested the example only using simulated hardware and the real hardware.