Repository navigation
codegen change for skipping InvalidRepeatedCapabilityError validation when not present in config.py - #2244
Draft
mohit-emerson wants to merge 1 commit into
Draft
codegen change for skipping InvalidRepeatedCapabilityError validation when not present in config.py#2244mohit-emerson wants to merge 1 commit into
mohit-emerson wants to merge 1 commit into
Conversation
…or is not generated Drivers that have repeated capabilities but do not list InvalidRepeatedCapabilityError in extra_errors_used now pass repeated capability strings they cannot parse to the driver as-is, and the driver reports if they are invalid. Only a simple two-part range is expanded, and unsupported types raise TypeError. Drivers that list the error generate the same code as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 88 88
Lines 22830 22830
=======================================
+ Hits 20118 20119 +1
+ Misses 2712 2711 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mohit-emerson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[] I've updated CHANGELOG.md if applicable.[] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
InvalidRepeatedCapabilityErroris not generatedDrivers that have repeated capabilities but do not list
InvalidRepeatedCapabilityErrorinextra_errors_usednow pass repeated capability strings they cannot parse to the driver as-is, and the driver reports if they are invalid. Only a simple two-part range is expanded, and unsupported types raise TypeError. Drivers that list the error generate the same code as before.List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Validations