Skip to content

Create a separate pyproject.toml for the jupyter notebooks - #191

Merged
mjohanse-emr merged 5 commits into
mainfrom
users/mjohanse/separate_notebook_venv
Oct 15, 2026
Merged

mjohanse-emr merged 5 commits into
mainfrom
users/mjohanse/separate_notebook_venv

Conversation

@mjohanse-emr

@mjohanse-emr mjohanse-emr commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

  • Creates a separate pyproject.toml for the jupyter notebook examples.
  • Updates the jupyter notebooks to refer to the venv created by this new pyproject.toml
  • Updates the notebooks' README to reflect the new steps to create and use the venv.
  • Removes jupyter notebook specific dependencies from the main ni.datastore pyproject.toml and relocks.

Why should this Pull Request be merged?

#92
AB#3744853

  • Makes it easier and more straightforward to run the jupyter notebook examples
  • Removes jupyter specific dependencies from the main package's pyproject.toml

What testing has been done?

  • I ran all of the notebooks successfully using the new venv.
  • I ran all unit and acceptance tests. They all passed.

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…ave.

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
… used for acceptance tests.

Signed-off-by: Michael Johansen <michael.johansen@emerson.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency separation is coherent, with only a minor setup-documentation correction remaining.

1 open finding
What changed in this PR

Separates the notebook examples from the main ni.datastore development environment, addressing #92.

Changes:

  • Adds a shared notebook Poetry project with an in-project virtual environment.
  • Removes notebook dependencies from the root project and updates its lockfile.
  • Updates setup instructions and notebook environment metadata.
File Description
pyproject.toml Removes notebook-specific dependencies.
poetry.lock Removes associated dependencies and updates groups.
examples/​notebooks/​voltage-regulator/​publish_waveforms.ipynb Updates Python version metadata.
examples/​notebooks/​README.md Documents dedicated environment setup.
examples/​notebooks/​query/​query_metadata.ipynb Updates kernel and Python metadata.
examples/​notebooks/​query/​query_measurements.ipynb Updates kernel and Python metadata.
examples/​notebooks/​query/​publish_sample_data.ipynb Updates Python version metadata.
examples/​notebooks/​pyproject.toml Defines shared notebook dependencies and local packages.
examples/​notebooks/​publish/​publish_batch.ipynb Updates Python version metadata.
examples/​notebooks/​poetry.toml Enables an in-project virtual environment.
examples/​notebooks/​overview/​publish_measurement.ipynb Updates Python version metadata.
examples/​notebooks/​extension-attributes/​extension_attributes.ipynb Updates kernel and Python metadata.
examples/​notebooks/​alias/​alias.ipynb Updates kernel and Python metadata.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/notebooks/README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mjohanse-emr
mjohanse-emr marked this pull request as ready for review October 15, 2026 13:56
@mjohanse-emr
mjohanse-emr requested a review from a team as a code owner October 15, 2026 13:56
@mjohanse-emr
mjohanse-emr merged commit 6ce1179 into main Oct 15, 2026
32 checks passed
@mjohanse-emr
mjohanse-emr deleted the users/mjohanse/separate_notebook_venv branch October 15, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants