Repository navigation
Create a separate pyproject.toml for the jupyter notebooks - #191
Merged
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
…ave. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
… used for acceptance tests. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency separation is coherent, with only a minor setup-documentation correction remaining.
1 open finding
What changed in this PR
Separates the notebook examples from the main ni.datastore development environment, addressing #92.
Changes:
- Adds a shared notebook Poetry project with an in-project virtual environment.
- Removes notebook dependencies from the root project and updates its lockfile.
- Updates setup instructions and notebook environment metadata.
| File | Description |
|---|---|
| pyproject.toml | Removes notebook-specific dependencies. |
| poetry.lock | Removes associated dependencies and updates groups. |
| examples/notebooks/voltage-regulator/publish_waveforms.ipynb | Updates Python version metadata. |
| examples/notebooks/README.md | Documents dedicated environment setup. |
| examples/notebooks/query/query_metadata.ipynb | Updates kernel and Python metadata. |
| examples/notebooks/query/query_measurements.ipynb | Updates kernel and Python metadata. |
| examples/notebooks/query/publish_sample_data.ipynb | Updates Python version metadata. |
| examples/notebooks/pyproject.toml | Defines shared notebook dependencies and local packages. |
| examples/notebooks/publish/publish_batch.ipynb | Updates Python version metadata. |
| examples/notebooks/poetry.toml | Enables an in-project virtual environment. |
| examples/notebooks/overview/publish_measurement.ipynb | Updates Python version metadata. |
| examples/notebooks/extension-attributes/extension_attributes.ipynb | Updates kernel and Python metadata. |
| examples/notebooks/alias/alias.ipynb | Updates kernel and Python metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mjohanse-emr
marked this pull request as ready for review
October 15, 2026 13:56
dixonjoel
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this Pull Request accomplish?
ni.datastorepyproject.toml and relocks.Why should this Pull Request be merged?
#92
AB#3744853
What testing has been done?