Conversation
Owner
|
Thanks for this @SAY-5. Before we go much further I want to investigate changes to the Meaning that some of these changes might be redundant, and some of the existing code might also be redundant. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions passed as dictionary values currently lose their PEP 678 notes, even though the
exc_infopath preserves them. This appends an exception’s own notes to the existing class/message string in order, preserving empty and multiline notes and leaving note-free output unchanged.Exception groups keep their existing nonrecursive summary and gain their own notes. Child exceptions and their notes are still rendered through
exc_info; this change does not add recursive group formatting. Related to #67.The regression covers dictionary, nested dictionary, and list values through every available formatter, string subclasses, empty/custom exception messages, and group-own notes. On Python 3.13.0, the new tests fail against the unchanged implementation (12 failures, 6 passing controls) and pass with the fix (18 passed); the full available suite passes (171 tests, stdlib JSON and orjson). Black passes. Pylint and mypy were run and report only the same missing
msgspecdependency diagnostics as the unchanged baseline. The msgspec backend and other Python/platform versions have not been tested locally.This PR was prepared with AI assistance (OpenAI Codex).