SPIDecoder: Add CPHA and LSB/MSB option - #1105
Open
dj-bauer wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
As mentioned in #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement 2 TODOs for the SPIDecoder.
This commit moved the sampling of a specific bit into a separate helper function
sampleBit(...)as it's now called twice depending on the value of CPHA.As the state machine already tracks of falling and rising edges it was just necessary to sample depending on CPHA.
The MSB/LSB implementation was rather trivial as it expands on the existing byte modification.