-
Notifications
You must be signed in to change notification settings - Fork 132
feat: add troubleshooting section to monitoring and logging #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mjang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't have access to this console, I can't give this a complete review. So I've some basic readability suggestions.
Question: is there a way to review metrics from the CLI? If so, I'm guessing our users might prefer that method.
Sounds good! I also put a screenshot of what the Events page looks like in the PR description in case that helps.
I don't think there's a way via the CLI. Google's documentation on reading metrics says that the three methods are through the Google Cloud console, the API, and different language-specific client libraries. We currently have examples of using the console and the API, but none of any libraries (not sure how populate those are). |
e563147 to
de10205
Compare
JTorreG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with nits
NGINXaaS now provides events to users in case of failures exporting logs and metrics to Google Cloud. This adds a troubleshooting section to the logs and metrics pages with instructions on how to view these events. I'm thinking once the events page starts showing more events and it turns more into an Acitivty Log, we can have a seperate page with more details.
de10205 to
b9dc952
Compare
✅ Deploy Preview will be available once build job completes!
|
Proposed changes
NGINXaaS now provides events to users in case of failures exporting logs and metrics to Google Cloud. This adds a troubleshooting section to the logs and metrics pages with instructions on how to view these events.
I'm thinking once the events page starts showing more events and it turns more into an Activty Log, we can have a separate page with more details.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩