fix: ensure delta metric values are never negative#1690
Open
valyria257 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 84.99% 84.98% -0.01%
==========================================
Files 104 104
Lines 13579 13583 +4
==========================================
+ Hits 11541 11544 +3
- Misses 1524 1525 +1
Partials 514 514
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
If nginx reset the values of the counters used for these metric values, then the gauge values will be negative because they are calculated based on the current value minus the previous value. Since these gauges are tracking counts, it doesn't make sense for them to be negative. The current value should always be greater than the previous because it is based on a counter, unless it's been reset to 0. Thus, this will set the gauge values to the current value, most likely 0, if the delta is negative.
valyria257
force-pushed
the
nginxaas-1520-non-neg-metrics
branch
from
377b4f3 to
22de71c
Compare
valyria257
changed the title
| } | ||
|
|
||
| // increase calculates the delta value (difference) from monotonically increasing counters. | ||
| // If the current value is less than previous value, in the case of a rest, we take the current value. |
UnwashedMeme
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
If nginx reset the values of the counters used for these metric values,
then the gauge values will be negative because they are calculated
based on the current value minus the previous value.
Since these gauges are tracking counts, it doesn't make sense for them
to be negative. The current value should always be greater than the
previous because it is based on a counter, unless it's been reset to 0.
Thus, this will set the gauge values to the current value, most likely
0, if the delta is negative.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)