Deprecate basic_facade_builder::add_facade<F, true>#27
Open
mingxwa wants to merge 1 commit intongcpp:mainfrom
Open
Deprecate basic_facade_builder::add_facade<F, true>#27mingxwa wants to merge 1 commit intongcpp:mainfrom
basic_facade_builder::add_facade<F, true>#27mingxwa wants to merge 1 commit intongcpp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per user feedback, the syntax of
basic_facade_builder::add_facade<F, true>is not intuitive enough. This PR deprecated that usage, and introduced a more explicit APIadd_facade_with_substitution.Changes
details::add_facade_deprecation_traitsto generate deprecation diagnostics.basic_facade_builder::add_facade_with_substitution.