Closed
Conversation
FNAND0
approved these changes
Jul 12, 2024
ghost
force-pushed
the
packaging
branch
2 times, most recently
from
e5bb5ff to
e558853
Compare
daixtrose
reviewed
Aug 6, 2024
Collaborator
daixtrose
left a comment
daixtrose
left a comment
There was a problem hiding this comment.
I appreciate the effort. Feel free to ignore my comments and proceed with a merge. Since I am currently away from computers where I can test the changes, I kindly ask for other reviewers to give green light.
Generally speaking: The changes point into the right direction. Making libnfc's CMake system truly platform independent is still some work to be done. I currently take a third deep dive into Craig Scott's book which got some chapters added about release and dependency management. You might find these helpful.
Co-authored-by: Markus Werle <daixtrose@users.noreply.github.com>
ghost
mentioned this pull request
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #735.
The propose of this PR is as follows.
LibNFCConfig.cmakerelocatable.GNUInstallDirsto simplify code.BUILD_MANUALandINSTALL_BUNDLEfor user discretion.zipas the CPack default generator (let others usecpack -G "xxxx").FindLIBUSB.cmake.The reason why I changed
UTILS-SOURCESandEXAMPLES-SOURCEStoSOURCESis that I was going to fixFixBundle.cmake.inbut it failed serveral times and finally I gave up. :(ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}is unneeded which is built-in default.