Update nfcore modules in spatialaxe - #184
Conversation
XENIUM_PATCH_STITCH failed with 'unrecognized arguments: --min-transcripts-per-cell 50'. When stitch_transcripts.py was split into xenium_patch_stitch_transcripts.py + xenium_patch_stitch_postprocess.py, the --min-transcripts-per-cell argument and its small-cell filter were dropped from the transcripts script, but conf/modules.config still injects the flag. - restore the argument + post-stitch small-cell filter (reassign transcripts of sub-threshold cells to noise, drop their polygons) - repoint tests/test_xenium_patch/test_stitch_transcripts.py from the deleted modules/.../resources/usr/bin path to bin/ (broken since the PR nf-core#154 refactor) - add TestMinTranscriptsFilter: filter behaviour, no-op control, and a subprocess CLI test reproducing the exact production invocation - remove the orphan bin/stitch_transcripts.py (superseded, unused) Validated in the module's sopa container: 15 passed.
fix(xenium_patch): restore --min-transcripts-per-cell in stitch script
heylf
left a comment
There was a problem hiding this comment.
Some minor comments also from me.
|
@khersameesh24 please check your PR again. Probably you need to revert a lot back because we tackled now already thigns that you tried to solve. I thing what is only left is your updated for some modules. |
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 4.0.3. For more documentation on how to update your pipeline, please see the Synchronisation documentation. |
|
❌ nf-test failed with latest Nextflow versionNote Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
See the full run for details. |
template v4.0.2changesBaysor- Bayorrun,segfree,previewProseg-proseg,proseg2baysorOPT-flip,track,statmeta.ymlfilessnapshotcloses #178