Make release 1.0.0 - #82
Conversation
Implement rclone
Generate MultiQC Report with `comparechecksum` tables and input samplesheet
Implement review suggestions
Add memory definition to avoid failing on seqera platform
|
Hi @mazzalab and @ewels, |
LouisLeNezet
left a comment
There was a problem hiding this comment.
Hi,
You will found a few comments below, but I don't see any issue.
On a more general aspect, would it be possible to also use file level informations in the input samplesheet.
Would something like the following be possible:
sample,input,output_path,checksum_md5
sample,ftp://url/my_file.txt,output_path/data,0e646ea1c354aed1654|
Hi @LouisLeNezet, thank you so much for taking the time to review the pipeline and for your suggestions! |
Implement reviewer's suggestions #3
|
Hi @LouisLeNezet, we have addressed your suggestions and implemented the necessary changes. When you have the time would you mind taking a look at the code again and letting us know what you think? Also, regarding your question:
This is not currently supported. For now, we intentionally kept the checksum input format aligned with the checksum file expected by Please let me know if there is anything I missed. |
LouisLeNezet
left a comment
There was a problem hiding this comment.
I don't see anything blocking code wise.
Just a little comment bellow on unittest coverage.
The code is clean and well documented, you might just need at some point to think about a logo 😉
There was a problem hiding this comment.
For this subworkflow, it could be nice to have a dedicated nf-test, so that you could easily test the different input / warning / error conditions.
You can also test only a function like function "validateInputParameters" in a function.nf.test.
This way you can test each condition without running the whole pipeline.
This can be an issue for now, if you want to release.
There was a problem hiding this comment.
Yes, this makes sense. I will go ahead and open an issue to include this afterwards :)
mazzalab
left a comment
There was a problem hiding this comment.
I don't see problems. It looks like a good review
|
Thank you all for your time and suggestions! |
Change release date for v1.0.0
Closes #80:
AddedRCLONEmodules in multiqc report (@delfiterradas, review by @atrigila).--downloadparameter when working with remote directories and SHA checksums (@delfiterradas, review by @atrigila, @apeltzer and @antoniasaracco).RCLONE_CHECKandRCLONE_CHECKSUMmodules from nf-core (@delfiterradas, review by @atrigila and @antoniasaracco).FixedRCLONE_modules, enhance source and destination path handling, add localcreate_filter_listmodule and other small fixes (@delfiterradas, review by @atrigila).rclonemodules and nf-tests to sort generated report files for deterministic snapshots (@atrigila, review by @delfiterradas and @antoniasaracco).--one-wayfrom rclone/checksum confi (@delfiterradas, review by @atrigila and @antoniasaracco).files_to_copy.txavoiding error with write permissions in work directory (@delfiterradas, review by @atrigila and @antoniasaracco).