Skip to content

Make release 1.0.0 - #82

Merged
delfiterradas merged 392 commits into
mainfrom
dev
Sep 28, 2026
Merged

delfiterradas merged 392 commits into
mainfrom
dev

Conversation

@delfiterradas

@delfiterradas delfiterradas commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #80:

Added

Fixed

@delfiterradas

Copy link
Copy Markdown
Contributor Author

Hi @mazzalab and @ewels,
Thanks so much for taking the time to review the PR and for all the helpful suggestions! I’ve gone through all the comments and implemented the requested changes. Whenever you have a chance, it would be great if you could have another look at the updated version and let me know what you think :)

@LouisLeNezet LouisLeNezet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

You will found a few comments below, but I don't see any issue.

On a more general aspect, would it be possible to also use file level informations in the input samplesheet.
Would something like the following be possible:

sample,input,output_path,checksum_md5
sample,ftp://url/my_file.txt,output_path/data,0e646ea1c354aed1654

Comment thread conf/modules.config Outdated
Comment thread conf/modules.config Outdated
Comment thread conf/test_full.config
Comment thread docs/images/datasync-nf-metro.mmd
Comment thread docs/output.md Outdated
Comment thread subworkflows/local/utils_nfcore_datasync_pipeline/main.nf
Comment thread tests/main_full.nf.test.snap
Comment thread workflows/datasync.nf Outdated
Comment thread workflows/datasync.nf Outdated
Comment thread CHANGELOG.md Outdated
@delfiterradas

delfiterradas commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @LouisLeNezet, thank you so much for taking the time to review the pipeline and for your suggestions!
I will start working on the changes in #93 and can let you know when it is done

@delfiterradas

Copy link
Copy Markdown
Contributor Author

Hi @LouisLeNezet, we have addressed your suggestions and implemented the necessary changes.

When you have the time would you mind taking a look at the code again and letting us know what you think? ☺️

Also, regarding your question:

On a more general aspect, would it be possible to also use file level informations in the input samplesheet. Would something like the following be possible:

sample,input,output_path,checksum_md5
sample,ftp://url/my_file.txt,output_path/data,0e646ea1c354aed1654

This is not currently supported. For now, we intentionally kept the checksum input format aligned with the checksum file expected by rclone checksum, which simplifies both parsing and validation. We could consider supporting file level checksums directly in the samplesheet in a future iteration.


Please let me know if there is anything I missed.
Thank you!

@LouisLeNezet LouisLeNezet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything blocking code wise.
Just a little comment bellow on unittest coverage.
The code is clean and well documented, you might just need at some point to think about a logo 😉

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this subworkflow, it could be nice to have a dedicated nf-test, so that you could easily test the different input / warning / error conditions.
You can also test only a function like function "validateInputParameters" in a function.nf.test.
This way you can test each condition without running the whole pipeline.

This can be an issue for now, if you want to release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense. I will go ahead and open an issue to include this afterwards :)

@mazzalab mazzalab left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems. It looks like a good review

@delfiterradas

Copy link
Copy Markdown
Contributor Author

Thank you all for your time and suggestions!

Change release date for v1.0.0
@delfiterradas
delfiterradas merged commit e453795 into main Sep 28, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make release

8 participants