Repository navigation
[stable35] perf(editor): only serialize markdown on update when it is read - #9529
Merged
Merged
Conversation
CollaborativeEditor serialized the whole document to markdown on every editor update to emit `update:content`, even when no listener uses the result. On large documents this blocks every keystroke, especially in Chromium where prosemirror-markdown's serializer is quadratic in the output size. Emit the markdown as a getter so it is only serialized when a listener reads it. Benchmark on a 500 kB markdown document (headings, paragraphs, lists with marks), headless browsers against a local instance, median per step, before -> after: Chromium: - typing (cursor at start): 981 ms -> 67 ms - typing (cursor at end): 933 ms -> 34 ms - toggle bold on a word: 930 ms -> 50 ms - editor update handlers: ~870 ms -> <1 ms Firefox: - typing (cursor at start): 125 ms -> 76 ms - typing (cursor at end): 55 ms -> 47 ms - toggle bold on a word: 67 ms -> 88 ms (within noise) - editor update handlers: ~9 ms -> 1 ms Large tables are not affected by this change; their cost lies elsewhere. Related to #908 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
backportbot
Bot
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
November 4, 2026 08:19
backportbot
Bot
added
3. to review
performance 🚀
AI assisted
mejo-
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #9525