Repository navigation
Conversation
getFileForSession() returned the node of a single-file share without checking it against the session's document, so the share token passed with push, sync and save could belong to a different file. Require the resolved file id to match the session document id. Alaready fixed in stable35 and above, where getFileByIdFromShare() does the same check, as part of #9062. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
benjaminfrueh
approved these changes
Nov 3, 2026
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Member
Author
|
/backport! to stable33 |
Member
Author
|
/backport! to stable32 |
Member
Author
|
/backport! to stable31 |
blizzz
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFileForSession() returned the node of a single-file share without checking it against the session's document, so the share token passed with push, sync and save could belong to a different file. Require the resolved file id to match the session document id.
Alaready fixed in stable35 and above, where getFileByIdFromShare() does the same check, as part of #9062.
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)