Conversation
Keep Changes when there are no rendered differences. Limit initial positioning, stop on reader input, and show documents before measuring navigation targets. Assisted-by: Codex:gpt-6-astra Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open Full documents when a comparison has rendered differences, including formatting changes. Keep Changes for identical or syntax-only comparisons so their messages stay visible.
Wait until the editors are visible and have usable dimensions before positioning the first change. Stop adjusting after the layout settles, the reader interacts, or three attempts. Show the document panes before measuring a change selected by the reader.
Review point: confirm keeping Changes when there are no rendered differences.
Backport: #9215, pending the stable35 decision.
Tests
All 27 comparison component and factory tests passed locally. Tests caught deliberately broken input cancellation, correction limits and layout settling. The combined main and stable35 changes each passed 81 browser and memory checks.
AI