Skip to content

Fix link bubble behaviour - #9156

Closed
As3r1408 wants to merge 2 commits into
nextcloud:mainfrom
As3r1408:fix-link-bubble-clean
Closed

As3r1408 wants to merge 2 commits into
nextcloud:mainfrom
As3r1408:fix-link-bubble-clean

Conversation

@As3r1408

@As3r1408 As3r1408 commented Sep 2, 2026

Copy link
Copy Markdown

📝 Summary

  • Resolves: -

This improves link interaction in read-only mode.

Previously, clicking a link in read-only mode could open the link bubble instead of directly navigating to the linked destination. This change makes links behave more naturally in read-only mode by opening the destination directly when clicked.

The existing link bubble behaviour in editing mode is preserved, including the ability to use the bubble for interacting with links without immediately navigating away.

While making this change, an issue was also encountered where toggling between the link display options could leave the context menu open and briefly show both options as selected. This was fixed as part of the same change so that the menu closes correctly after changing the link display option.

Related to nextcloud/collectives#1026.

🖼️ Screenshots

🏚️ Before 🏡 After
imageimage image image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: As3r1408 <chavezpalpanaaronsamuel@gmail.com>
@max-nextcloud

Copy link
Copy Markdown
Collaborator

Hi @As3r1408
Thanks for your contribution and welcome!

@max-nextcloud

Copy link
Copy Markdown
Collaborator

I think we discussed this and the main reason for having the link bubble in read only mode was consistency with the edit mode.

Briefly checked the linked issue but could not find anything about the discussion.

@mejo- I think you looked into this more than I did. What's your take on it?

@As3r1408

As3r1408 commented Sep 2, 2026

Copy link
Copy Markdown
Author

I think we discussed this and the main reason for having the link bubble in read only mode was consistency with the edit mode.

Briefly checked the linked issue but could not find anything about the discussion.

@mejo- I think you looked into this more than I did. What's your take on it?

I just checked the related issue, turns out I misread something in there, the issue was actually talking about link previews, not the link bubbles like I thought, that's my bad 😅

I understand the thing about consistency, I just thought it would be better UX-wise

@mejo-

mejo- commented Sep 15, 2026

Copy link
Copy Markdown
Member

Thanks for your contribution @As3r1408, it's much appreciated. We decided to change the behaviour to always follow the link on click (edit and view mode) instead. See #9202. And don't hesitate to give it a try and report back what you think about it.

@mejo- mejo- closed this Sep 15, 2026
@As3r1408
As3r1408 deleted the fix-link-bubble-clean branch September 15, 2026 12:49
@As3r1408
As3r1408 restored the fix-link-bubble-clean branch September 15, 2026 12:49
@As3r1408
As3r1408 deleted the fix-link-bubble-clean branch September 15, 2026 12:52
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants