fix: update ShowImageModal to use fullUrl for show original image ins… - #8924
Open
mosi-kha wants to merge 1 commit into
Open
fix: update ShowImageModal to use fullUrl for show original image ins…#8924mosi-kha wants to merge 1 commit into
mosi-kha wants to merge 1 commit into
Conversation
…tead of preview Signed-off-by: mostafa khaki <mostafakhaki00@gmail.com>
mosi-kha
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
July 28, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Clicking an embedded image opened the modal on
currentImage.previewUrl— the1024x1024 preview, upscaled to an 80vh modal and visibly soft.
fullUrl(theoriginal, same route +
&preferRawImage=1) was already on the attachment objectand unused, so this just points the modal's
<img>at it.Inline rendering is untouched — documents still load previews, the original is
fetched only on an explicit click. Also matches
handleAttachmentClick(), whichalready uses
fullUrl/ the Viewer; the image modal was the only click-throughstill showing a preview.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)