Skip to content

Improving voice messages#6109

Merged
mahibi merged 2 commits into
masterfrom
issue-6093-improve-waveform
May 28, 2026
Merged

Improving voice messages#6109
mahibi merged 2 commits into
masterfrom
issue-6093-improve-waveform

Conversation

@rapterjet2004
Copy link
Copy Markdown
Contributor

@rapterjet2004 rapterjet2004 commented Apr 23, 2026

🚧 TODO

  • when starting to play another voice message while the first one is played back, the pause button of the first one should be replayed with the play button
  • it would be nice if the middle center of the circle would be the marker to color the vertical lines. Right now it seems to be the right border of the circle
  • debug playButton state issue

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Apr 23, 2026
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Apr 23, 2026
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24846764223/artifacts/6607329931
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24893204070/artifacts/6626109472
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i rebased on master an d fixes the conflicts.

I see this behavior:
sometimes it happens that the play button of one message controls the playback in another message

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25908980894/artifacts/7013499506
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 force-pushed the issue-6093-improve-waveform branch from 4df0e69 to 9de8088 Compare May 21, 2026 17:03
rapterjet2004 and others added 2 commits May 28, 2026 15:27
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the issue-6093-improve-waveform branch from 9de8088 to a837854 Compare May 28, 2026 13:35
@mahibi mahibi merged commit fcfa8a8 into master May 28, 2026
12 of 17 checks passed
@mahibi mahibi deleted the issue-6093-improve-waveform branch May 28, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

further improve voice messages

3 participants