feat(navigation): add LoadAdditionalEntriesListener - #2885
Open
enjeck wants to merge 1 commit into
Open
Conversation
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
mejo-
reviewed
Aug 10, 2026
| $context->registerEventListener(DatasourceEvent::class, AnalyticsDatasourceListener::class); | ||
| $context->registerEventListener(RenderReferenceEvent::class, TablesReferenceListener::class); | ||
| $context->registerEventListener(BeforeTemplateRenderedEvent::class, BeforeTemplateRenderedListener::class); | ||
| $context->registerEventListener(LoadAdditionalEntriesEvent::class, LoadAdditionalEntriesListener::class); |
Member
There was a problem hiding this comment.
I guess that the BeforeTemplateRenderedListener class still exists. Is it obsolete now that it's not loaded anymore? Or is it still used somewhere else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables' context navigation tests have been broken for a while due to changes in the server. It should be fixed in the server, but it's still flaky on our side, as it passes for me locally but fails here on CI. Hoping that following the advice given to use LoadAdditionalEntriesListener fixes it. See nextcloud/server#61120