fix(relation): edit row modal error and inline relation label display - #2879
Open
Koc wants to merge 1 commit into
Open
fix(relation): edit row modal error and inline relation label display#2879Koc wants to merge 1 commit into
Koc wants to merge 1 commit into
Conversation
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
marked this pull request as ready for review
August 9, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two UX issues around relation columns:
Bug 1
Opening a table URL that directly references a row in a relation table no longer throws the
fallbackFocusfocus-trap error. The edit row dialog now waits for the row data to be loaded, ensuring the modal has tabbable content before focus-trap activates.Reproducer
Expected result: table loaded, modal edit opened for a row
Actual result: error, no modal edit opened
Bug 2
Inline editing a relation cell now shows the selected relation label instead of the raw row id. The editor parses the cell value and normalizes option ids to the same numeric type, aligning inline editing with the modal editor.
Reproducer
Expected result: we can see label for selected relation
Actual result: there is an id of selected relation without label
🖼️ Screenshots
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)