Skip to content

fix(relation): edit row modal error and inline relation label display - #2879

Open
Koc wants to merge 1 commit into
mainfrom
fix/relation-edit-modal-and-inline-label-
Open

fix(relation): edit row modal error and inline relation label display#2879
Koc wants to merge 1 commit into
mainfrom
fix/relation-edit-modal-and-inline-label-

Conversation

@Koc

@Koc Koc commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This PR fixes two UX issues around relation columns:

Bug 1

Opening a table URL that directly references a row in a relation table no longer throws the fallbackFocus focus-trap error. The edit row dialog now waits for the row data to be loaded, ensuring the modal has tabbable content before focus-trap activates.

Reproducer

  1. Create a table with relation column
  2. Open edit row, url is something like https://nextcloud.test/apps/tables/#/table/32/row/21905
  3. Reload page or duplicate tab

Expected result: table loaded, modal edit opened for a row
Actual result: error, no modal edit opened

Bug 2

Inline editing a relation cell now shows the selected relation label instead of the raw row id. The editor parses the cell value and normalizes option ids to the same numeric type, aligning inline editing with the modal editor.

Reproducer

  1. Create a table with relation column
  2. Add a row with selected relation
  3. Reload page
  4. Start inline edit for relation column

Expected result: we can see label for selected relation
Actual result: there is an id of selected relation without label

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc marked this pull request as ready for review August 9, 2026 13:31
@Koc
Koc requested review from blizzz and enjeck as code owners August 9, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant