Fix(embedded) : column order, sort, scrolls overlays, refresh, table … - #2868
Open
taiebot wants to merge 1 commit into
Open
Fix(embedded) : column order, sort, scrolls overlays, refresh, table …#2868taiebot wants to merge 1 commit into
taiebot wants to merge 1 commit into
Conversation
…height * Fix: column order for embedded table Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * fix(widget): use fresh store data for rows/columns in ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix embed col order (#12) * Fix: column order for embedded table Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * fix(widget): use fresh store data for rows/columns in ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Embed scroll (#11) * Adjust height and z-index in ContentReferenceWidget (#7) Signed-off-by: taiebot <dedreuil@yahoo.fr> * Fix Change height of tables-content-widget to auto Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <dedreuil@yahoo.fr> Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix: enable sorting on ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix watcher for localViewSetting with debug logging Added a watcher for localViewSetting to log changes for debugging purposes. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix Remove debug watcher for localViewSetting Removed temporary debug watcher for localViewSetting. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix again Refactor loadColumnsFromBE to improve column sorting logic and add comments for clarity. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> Signed-off-by: taiebot <dedreuil@yahoo.fr>
7 tasks
enjeck
reviewed
Aug 6, 2026
| if (!this.dataStore) return | ||
| try { | ||
| if (this.isView) { | ||
| await this.dataStore.loadColumnsFromBE({ view: this.richObject }) |
Contributor
There was a problem hiding this comment.
the reference provider (ContentReferenceHelper) never puts columnSettings on the rich object. So inside loadColumnsFromBE the meta-column append doesn't seem to do anything?
Comment on lines
279
to
+325
| @@ -285,8 +318,11 @@ export default { | |||
| .nc-table { | |||
| min-width: var(--widget-content-width); | |||
|
|
|||
| :where(.options.row) { | |||
| display: none; | |||
| :deep(.options.row) { | |||
| height: 0 !important; | |||
| overflow: hidden !important; | |||
| margin: 0 !important; | |||
| padding: 0 !important; | |||
Contributor
There was a problem hiding this comment.
From your gif, i only see vertical scrolling. Did you test horizontal too?
| elementId: this.richObject.id, | ||
| rows: this.richObject.rows, | ||
| }) | ||
| return |
Contributor
There was a problem hiding this comment.
why remove this early return? for a table embed this now runs loadRowsFromBE, which hits /apps/tables/row/table/{id} and returns the full row set, whereas the reference only embedded about 100 rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
View order
Widget order
a little gif sorry the first seconds are frozen
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)