Repository navigation
Conversation
51b59d0 to
e6d4671
Compare
susnux
left a comment
There was a problem hiding this comment.
Approve for the icons, but really unsure about the "tests".
Not really sure about the usefulness of this tests, looks like something AI did because it was asked for any test, but nothing that really tests something meaningful.
Why? Because this heavily mocks things and then expects some specific CSS classes that easily can break at library updates just for a "visual" test. Moreover it plugs into the components private implementation for doing so.
Meaning I am not sure those tests have any benefit, if they turn red it probably just means dependency has changed and tests need to be adjusted, but not that the code itself broke.
So this is more of the category: tests for the tests sake and nobody will update them, except for blindly added AI updates.
From my point of view the tests are really low quality and look like most of our PHP unit tests, which really only test the implementation, not the function.
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
…plate Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
e6d4671 to
5f8acdc
Compare
Summary
Same as #65536 for the apps that are already on Vue 3, one commit per app:
icon-loading*becomesNcLoadingIcon, the othericon-*classes become MDI icons.Two of these were broken since the Vue 3 migrations. The template picker overlay was empty, because
NcEmptyContenthas noiconprop and no default slot anymore in nextcloud-vue 9. The "Load more results" spinner never showed: the view passed:iconClasswhileLegacySearchResultonly has aniconprop, andloadMore()never set the loading state in the first place. Neither is on stable35, so no backport.What's left out:
icon-userin the comments mention data, sinceNcRichContenteditablerequires an icon class there, and the result icons of the legacy unified search, which come as classes from the search providers.No screenshot for comments: the Comments sidebar tab doesn't load comments at all right now, that's a separate bug.
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.