Skip to content

perf(core): read the user status from initial state - #64123

Merged
artonge merged 1 commit into
masterfrom
perf/noid/account-menu-user-status-initial-state
Sep 9, 2026
Merged

perf(core): read the user status from initial state#64123
artonge merged 1 commit into
masterfrom
perf/noid/account-menu-user-status-initial-state

Conversation

@pringelmann

@pringelmann pringelmann commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

user_status already puts the current status into every logged-in page's initial state, but AccountMenu.vue refetched it over OCS in created(). Reading the initial state instead saves a request and a duplicate query per page load, and the badge is there on first paint.

Also drops the :key hack on NcAvatar, which only existed because the status used to arrive late.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes: no visual change
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (tests, reviewed)

@pringelmann pringelmann added this to the Nextcloud 36 milestone Sep 8, 2026
@pringelmann pringelmann self-assigned this Sep 8, 2026
@pringelmann
pringelmann requested a review from a team as a code owner September 8, 2026 13:51
@pringelmann
pringelmann requested review from skjnldsv and removed request for a team September 8, 2026 13:51
@pringelmann pringelmann added the 3. to review Waiting for reviews label Sep 8, 2026
@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@pringelmann
pringelmann requested a review from susnux September 8, 2026 15:48
@pringelmann
pringelmann force-pushed the perf/noid/account-menu-user-status-initial-state branch from 04f8094 to 965d773 Compare September 8, 2026 15:55
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the perf/noid/account-menu-user-status-initial-state branch from 965d773 to 5db62f4 Compare September 9, 2026 07:26
@artonge
artonge merged commit be7a033 into master Sep 9, 2026
144 of 147 checks passed
@artonge
artonge deleted the perf/noid/account-menu-user-status-initial-state branch September 9, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants