[stable29] fix(Database): Use real idle-timer to prevent lastInsertId being reset on MariaDB/MySQL - #62709
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable29] fix(Database): Use real idle-timer to prevent lastInsertId being reset on MariaDB/MySQL#62709backportbot[bot] wants to merge 1 commit into
lastInsertId being reset on MariaDB/MySQL#62709backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
requested review from
CarlSchwan,
DerDreschner and
nickvergessen
July 30, 2026 16:32
backportbot
Bot
added
bug
3. to review
DerDreschner
force-pushed
the
backport/62697/stable29
branch
from
August 9, 2026 21:51
116c49e to
4178e56
Compare
DerDreschner
marked this pull request as ready for review
August 9, 2026 21:52
DerDreschner
approved these changes
Aug 9, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…set on MariaDB/MySQL The previous implementation of the idle timer runs on a strict 30 second interval and sends a dummy `SELECT` statement to keep the connection open. This generates issues with the `lastInsertId` on long-running tasks (like our CI pipeline), as the MariaDB documentation clearly states: > If the last query wasn't an INSERT or UPDATE statement or if the modified table does not have a column with the AUTO_INCREMENT attribute and LAST_INSERT_ID was not used, this function will return zero. Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id To mitigate that, this commit now uses a real idle-timer per connection instead. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
backport/62697/stable29
branch
from
August 9, 2026 22:04
4178e56 to
c47a6e1
Compare
| $this->tablePrefix = $params['tablePrefix']; | ||
| // the DBAL 3.8 params are a sealed array shape that predates this key, so it is | ||
| // reached through isset() like the ones above instead of a null coalesce | ||
| if (isset($params['activity_notifier']) && $params['activity_notifier'] instanceof ConnectionActivityNotifier) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62697
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.