refactor(files): reduce duplication in node copy/move and tidy Node internals#60971
Draft
joshtrichards wants to merge 5 commits into
Draft
refactor(files): reduce duplication in node copy/move and tidy Node internals#60971joshtrichards wants to merge 5 commits into
joshtrichards wants to merge 5 commits into
Conversation
- Substantive changes are in copy() and move() - Other changes are unrelated modernization (constructor property promotion + elimination of outdated docblocks for functions already covered in interfaces) Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
+Clearer variable naming +Clear delineate NotPermissionException failure modes Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up
OC\Files\Node\Nodeby extracting shared copy/move target-path logic, isolating move-specific cache updates, and simplifying related property/docblock structure.Changes
For
copy()/move():prepareTargetPath()updateCachedFileInfoAfterMove()copy()/move()focused on operation-specific behavior and hooksmove()NotPermittedExceptionscenariosMisc:
rootandviewto promoted propertiesNode@internalannotations togetFileInfo()andisValidPath()@throwsdocumentation forOCP\Files\Node::copy()Notes
This reduces duplication in copy/move handling, makes the control flow in
Nodeeasier to follow, and cleans up surrounding type/documentation noise without intending to change behavior.Checklist
3. to review, feature component)stable32)AI (if applicable)