perf(files): keep systemtag and filecache joins index-friendly#60932
Open
solracsf wants to merge 2 commits into
Open
perf(files): keep systemtag and filecache joins index-friendly#60932solracsf wants to merge 2 commits into
solracsf wants to merge 2 commits into
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The system tag search joins compared
filecache.fileid(bigint) againstsystemtag_object_mapping.objectid(varchar). On MySQL/MariaDB this implicitly coerces theobjectidstring column to a number, which makes any index onobjectidunusable and turns the join into a full/BNL scan of the mapping table.Comparing as strings instead (
objectid = CAST(fileid AS CHAR)) keeps the index usable. On a 100k-row mapping table the systemtagmap access dropped from ~50k examined rows per outer row to 1, with identical results (objecttypeis filtered to 'files', whereobjectidis always the decimalfileid). Applied to both the search query and the tag-usage count query.Also, strip a lone
to_char()string cast when parsing partitioned join conditions (the previous branch duplicated the int-cast check and was dead code) so sharded setups extract the join columns correctly on Oracle.Checklist
3. to review, feature component)stable32)AI (if applicable)