Skip to content

test(user_ldap): mark testGetListOfIdsByDn as Large#60930

Open
miaulalala wants to merge 1 commit into
masterfrom
test/noid/user-ldap-large-annotation
Open

test(user_ldap): mark testGetListOfIdsByDn as Large#60930
miaulalala wants to merge 1 commit into
masterfrom
test/noid/user-ldap-large-annotation

Conversation

@miaulalala
Copy link
Copy Markdown
Contributor

@miaulalala miaulalala commented Jun 2, 2026 •
edited
Loading

Follow up to #60756

Summary

  • Adds #[Large] attribute to testGetListOfIdsByDn in AbstractMappingTestCase
  • The test inserts 14 rows and runs chunked IN queries against a real DB over a 66 640-element list — well into Large territory by PHPUnit size conventions
  • Allows the timeout enforcer (PR test(ci): enforce PHPUnit time limits with sensible timeout values #60739) to apply an appropriate limit and lets CI route slow tests correctly

Test plan

  • NOCOVERAGE=1 ./autotest.sh sqlite apps/user_ldap/tests/Mapping/ passes

🤖 Generated with Claude Code

@miaulalala miaulalala requested a review from a team as a code owner June 2, 2026 09:48
@miaulalala miaulalala requested review from Altahrim, artonge, come-nc, leftybournes, provokateurin and salmart-dev and removed request for a team June 2, 2026 09:48
@miaulalala
Copy link
Copy Markdown
Contributor Author

miaulalala commented Jun 2, 2026

/backport to stable34

@miaulalala miaulalala self-assigned this Jun 2, 2026
@miaulalala miaulalala added 3. to review Waiting for reviews tests Related to tests CI AI assisted labels Jun 2, 2026
@miaulalala miaulalala added this to the Nextcloud 35 milestone Jun 2, 2026
@miaulalala miaulalala enabled auto-merge June 2, 2026 10:05
@miaulalala
test(user_ldap): mark testGetListOfIdsByDn as Large
7d43864 
The test inserts 14 rows and runs 66640-element chunked IN queries against
the real DB, making it a Large test by PHPUnit size conventions.

Adding the #[Large] attribute allows the PHPUnit timeout enforcer to apply
the appropriate time limit and lets CI separate slow tests from fast ones.

Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@miaulalala miaulalala force-pushed the test/noid/user-ldap-large-annotation branch from bd71bf9 to 7d43864 Compare June 2, 2026 10:54
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Jun 2, 2026

It does not work, somehow the timeout is still 300

There was 1 risky test:

1) OCA\User_LDAP\Tests\Mapping\GroupMappingTest::testGetListOfIdsByDn
This test was aborted after 300 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews AI assisted backport-request CI tests Related to tests

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

3 participants

@miaulalala @come-nc @provokateurin