refactor(URLGenerator): split long imagePath() policy into easy to read to helpers + one shared primitive#60919
Draft
joshtrichards wants to merge 4 commits into
Draft
refactor(URLGenerator): split long imagePath() policy into easy to read to helpers + one shared primitive#60919joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Also fixes a couple presumed bugs Signed-off-by: Josh <josh.t.richards@gmail.com>
…readability/ Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
…avior Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This policy is long and monolithic; also includes duplicate logic. This splits the policy up into three policy-level self-documenting helpers along with a single shared primitive.
Small bug fix included: normalize
''to'core'before computing cache storage key.Notes
If this approach is deemed attractive, maybe we use it in some of the other long policy path resolving spots.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)