chore: Enable ESLint for apps and fix all errors by susnux · Pull Request #46082 · nextcloud/server

susnux · 2024-06-24T22:11:43Z

Summary

Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the apps/ prefix. Causing only core to be linted.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

st3iny

LGTM! There are npm build changes though.

nickvergessen · 2024-06-25T08:33:41Z

Nice find 🙈

ShGKme

Thanks!

Checked all the changes, looks good.
I expected much more changes 👀

The only thing I'm working about is removing the import. Having a file it is not easily possible to say if removing this line is safe. And strictly, each file with dialogs must have dialog styles.

import '@nextcloud/password-confirmation/dist/style.css'

ShGKme · 2024-06-25T09:53:49Z

+    "lint": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern",
+    "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"apps/$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix",


It's been worrying me for a year 🙈

susnux · 2024-07-01T11:51:16Z

/compile

susnux · 2024-07-02T10:17:01Z

Current blocker:
Some types are missing from our typings of OC / OCP, I created a PR so waiting for this and then a new release:

skjnldsv · 2024-07-09T08:02:18Z

Can we do that just after branch off 31 please 🙏

Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the `apps/` prefix. Causing only `core` to be linted. Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 24, 2024

susnux added this to the Nextcloud 30 milestone Jun 24, 2024

susnux requested a review from ShGKme June 24, 2024 22:11

susnux requested review from ChristophWurst, miaulalala, nickvergessen, skjnldsv and st3iny as code owners June 24, 2024 22:11

st3iny approved these changes Jun 25, 2024

View reviewed changes

st3iny reviewed Jun 25, 2024

View reviewed changes

Comment thread apps/federatedfilesharing/src/components/AdminSettings.vue