Skip to content

fix: report login flow completion and errors#192

Open
juliusknorr wants to merge 1 commit into
mainfrom
agent/fix-login-flow-feedback
Open

fix: report login flow completion and errors#192
juliusknorr wants to merge 1 commit into
mainfrom
agent/fix-login-flow-feedback

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

What changed

  • Pass the login UI dismissal callback through to the polling flow and invoke it after successful account creation.
  • Treat HTTP 404 from the Login Flow v2 polling endpoint as the expected pending state.
  • Stop retrying terminal polling failures and present them in a Login Failed alert.
  • Log Login Flow v2 startup and polling failures with useful error details.
  • Treat cancellation without an active polling task as an expected condition.

Why

The host app discarded the dismissal callback supplied by ServerAddressView, so a successful login was not explicitly reported back to the login UI. Polling also collapsed every unsuccessful response into a pending state, causing terminal server or network errors to retry indefinitely without visible feedback.

Impact

Successful browser-based login now closes the login UI and proceeds into the app. Expected pending responses remain silent, while genuine polling failures stop the flow and give the user an actionable error alert.

Validation

  • Built the iOCNotes scheme successfully for an iPhone 17 Pro simulator running iOS 27.0.
  • Installed and launched the resulting app in the simulator.
  • Confirmed the app process remained running without a launch failure.

@juliusknorr juliusknorr force-pushed the agent/fix-login-flow-feedback branch from 9fafaee to a647f95 Compare July 13, 2026 10:49
@juliusknorr juliusknorr requested review from i2h3 and mpivchev July 13, 2026 10:50
@juliusknorr juliusknorr added the bug Something isn't working label Jul 13, 2026
@juliusknorr juliusknorr marked this pull request as ready for review July 13, 2026 10:50
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Assisted-by: Codex:GPT-5
@juliusknorr juliusknorr force-pushed the agent/fix-login-flow-feedback branch from a647f95 to 3f3ca50 Compare July 14, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant