fix: report login flow completion and errors#192
Open
juliusknorr wants to merge 1 commit into
Open
Conversation
9fafaee to
a647f95
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: Codex:GPT-5
a647f95 to
3f3ca50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Login Failedalert.Why
The host app discarded the dismissal callback supplied by
ServerAddressView, so a successful login was not explicitly reported back to the login UI. Polling also collapsed every unsuccessful response into a pending state, causing terminal server or network errors to retry indefinitely without visible feedback.Impact
Successful browser-based login now closes the login UI and proceeds into the app. Expected pending responses remain silent, while genuine polling failures stop the flow and give the user an actionable error alert.
Validation
iOCNotesscheme successfully for an iPhone 17 Pro simulator running iOS 27.0.