feat(ui): fold the thread subject as the thread scrolls - #13543
feat(ui): fold the thread subject as the thread scrolls#13543CreatorOfBiontium wants to merge 2 commits into
Conversation
A long subject wrapped over several lines and pushed the message down, and the sticky header kept those lines on screen for the whole thread. Fold it to a single line as the thread scrolls instead, tied to the scroll position rather than to a timer, so that a reader who stops halfway finds it halfway. The header hands back the height the subject gives up. Without that, everything below moves up by as much on top of the scrolling that caused the fold, and the thread runs away from the finger; it also ties how fast the subject folds to how fast the thread moves, so neither can be chosen on its own. A line is measured in lh rather than --default-line-height, which the server sets to a bare ratio: subtracting it from a length voids the declaration it sits in, and the fold never ran at all. Scroll anchoring is off. The header changing height had the browser scroll back to compensate, which moved the thread over the mark that started the fold and unfolded it again, in a loop that got worse the longer the subject was. That loop is what sank the attempt in nextcloud#11754. The mobile offsets that compensated for the wrapping subject go with it, and the subject is indented past the back button that the app content lays over the header. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Tobiáš Vašťák <tobias.vastak@gmail.com>
Signed-off-by: Tobiáš Vašťák <tobias.vastak@gmail.com>
|
Thanks for the contribution |
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
Makes sense from the design side at least from the screen recordings.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
...also known as the great revival of #11754 (by Claude)
As the title says, folds the thread subject on scroll so there's actually space for reading emails on phones/smaller displays.
🤖 AI (if applicable)