Skip to content

fix: interactions in actions menu for mailboxes#13316

Merged
ChristophWurst merged 1 commit into
nextcloud:mainfrom
madbob:issue_9107
Jul 21, 2026
Merged

fix: interactions in actions menu for mailboxes#13316
ChristophWurst merged 1 commit into
nextcloud:mainfrom
madbob:issue_9107

Conversation

@madbob

@madbob madbob commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Here I've fixed the interaction with the "Rename" option (mentioned in #9107) but also with "Add subfolder" (having the same problem). Both inputs are reverted to the static label when the menu is closed.

I've also added a "Saving" animation for "Add subfolder", equivalent to the one already existing for "Rename".

Fixes #9107

Summary by CodeRabbit

  • Bug Fixes
    • Improved mailbox subfolder creation and rename flows with more reliable, clearly displayed loading states.
    • Prevented duplicate actions by disabling interactions while subfolder creation or renaming is in progress.
    • Ensured the navigation menu and related input/controls reset correctly when closing the menu, without interrupting active save operations.

@ChristophWurst

Copy link
Copy Markdown
Member

Thanks!

@ChristophWurst

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c2b1b96e-8e02-4c00-9d5c-d625a474a97d

📥 Commits

Reviewing files that changed from the base of the PR and between a8f328e and cf3350e.

📒 Files selected for processing (1)
  • src/components/NavigationMailbox.vue

📝 Walkthrough

Walkthrough

NavigationMailbox replaces shared editing and saving flags with dedicated subfolder and rename state. Creation and rename flows independently control loading, input availability, and menu-reset behavior.

Changes

Mailbox actions

Layer / File(s) Summary
Action state model
src/components/NavigationMailbox.vue
Introduces dedicated subfolder and rename flags, updates action rendering, and conditionally resets views when the menu closes.
Subfolder creation flow
src/components/NavigationMailbox.vue
Controls subfolder input and saving states during creation, then restores the label view after completion.
Mailbox rename flow
src/components/NavigationMailbox.vue
Tracks rename requests with renameSaving and clears the state when the request finishes or input opens.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: christophwurst, kesselb, gretad

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main mailbox actions-menu interaction fixes in the PR.
Linked Issues check ✅ Passed The changes address issue #9107 by letting rename exit when the menu closes and restoring the static label state.
Out of Scope Changes check ✅ Passed The added subfolder saving state and UI changes are part of the stated PR goals and are not out of scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ca30fafa-e9b1-4db3-893d-c29770d7eaa5

📥 Commits

Reviewing files that changed from the base of the PR and between e50eedf and 705da5e.

📒 Files selected for processing (1)
  • src/components/NavigationMailbox.vue

Comment thread src/components/NavigationMailbox.vue Outdated
Comment thread src/components/NavigationMailbox.vue
Signed-off-by: Roberto Guido <info@madbob.org>
@ChristophWurst

Copy link
Copy Markdown
Member

@coderabbitai review one final time before merge

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

@ChristophWurst I’ll perform a final full review of #13316 before merge.

✅ Action performed

Full review finished.

@ChristophWurst
ChristophWurst merged commit a21d05d into nextcloud:main Jul 21, 2026
42 checks passed
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable5.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to escape/end mailbox rename

2 participants