fix(http): prevent NPE by non-null controller parameters#12495
Merged
Conversation
kesselb
approved these changes
Mar 9, 2026
kesselb
reviewed
Mar 9, 2026
| * @param string $smtpUser | ||
| * @param string $smtpPassword | ||
| * @param string|null $imapPassword | ||
| * @param string|null $smtpPassword |
Contributor
There was a problem hiding this comment.
Could also drop the param phpdoc as they don't provide any additional information to the type hints.
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/http/controller-non-null-params
branch
from
9c82d58 to
8ab9849
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some controller params were nullable but only in the controller method and not the method passed into. This can lead to a NPE when the param is actually missing from a HTTP request.
For #11224